Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugins): check algorithm option for antd plugin #11629

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

Wxh16144
Copy link
Member

ref: #11156 (comment)

Co-authored-by: xiaohuoni [email protected]


#11163 拆分来解决

@vercel
Copy link

vercel bot commented Sep 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2023 6:08am

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f3c9ed0) 29.00% compared to head (acbdf98) 28.99%.

❗ Current head acbdf98 differs from pull request most recent head ffdffd9. Consider uploading reports for the commit ffdffd9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11629      +/-   ##
==========================================
- Coverage   29.00%   28.99%   -0.01%     
==========================================
  Files         484      484              
  Lines       14716    14718       +2     
  Branches     3480     3481       +1     
==========================================
  Hits         4268     4268              
- Misses       9692     9693       +1     
- Partials      756      757       +1     
Files Changed Coverage Δ
packages/plugins/src/antd.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeachScript PeachScript changed the title chore: prompt when adding an incorrect configuration refactor(plugins): check algorithm option for antd plugin Sep 11, 2023
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit 8a0cd22 into umijs:master Sep 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants