fix: using tsx loader to parse jsx files #11668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #11668 +/- ##
=======================================
Coverage 28.99% 28.99%
=======================================
Files 485 485
Lines 14729 14728 -1
Branches 3486 3486
=======================================
Hits 4271 4271
+ Misses 9701 9700 -1
Partials 757 757
☔ View full report in Codecov by Sentry. |
sorrycc
approved these changes
Sep 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11646 (reply in thread)
当 jsx 文件中使用了装饰器，我们应该还使用 tsx loader 去解析他，因为 esbuild transform 不支持在 js 里用装饰器（最新版除外，因为从 v0.18.5 开始已经支持了 ecma 新版 deco ）