feat: add mako config #12366
Merged
feat: add mako config #12366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Walkthrough本次更新在 Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
packages/preset-umi/src/features/mako/mako.ts (1)
15-21: 建议在代码中添加注释，解释为什么需要禁用mfsu和hmrGuardian。这有助于其他开发者理解这些更改的背景。
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!pnpm-lock.yaml
Files selected for processing (3)
- packages/preset-umi/package.json (1 hunks)
- packages/preset-umi/src/features/mako/mako.ts (1 hunks)
- packages/preset-umi/src/index.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/preset-umi/package.json
Additional comments not posted (2)
packages/preset-umi/src/features/mako/mako.ts (1)
8-10: 请确认是否有意将 Mako 的配置模式设置为空。如果是初始设置，建议在文档中说明。packages/preset-umi/src/index.ts (1)
60-60: 添加 Mako 模块的方式正确无误，使用了require.resolve来确保运行时解析，这是 Node.js 应用中的常见模式。
|
Size Change: +1.33 kB (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/preset-umi/src/features/mako/mako.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/preset-umi/src/features/mako/mako.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes：
1、添加 mako 配置（但暂不在文档中露出）
2、Umi 开启 Mako 时目前会给一个警告信息。
Summary by CodeRabbit
@umijs/bundler-mako版本0.4.14的依赖。