Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: upgrade webpack-5-chain #12393

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented May 15, 2024

close #12382
close #11969

升级依赖(这个依赖包的升级不涉及源码变化,只修复了 types 里的 typo)

Summary by CodeRabbit

  • 修复

    • 修正了 assetModuleFilename 方法签名中的拼写错误。
  • 维护

    • 更新了 webpack-5-chain 依赖版本,从 8.0.1 升级到 8.0.2
    • 修改了 webpack-5-chain 包中的作者邮箱地址。

fz6m and others added 2 commits May 16, 2024 00:42
Co-authored-by: weixue <[email protected]>
Co-authored-by: 17hz <[email protected]>
Co-authored-by: day-xue <[email protected]>
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:46pm

Copy link

coderabbitai bot commented May 15, 2024

Walkthrough

此次更新涉及 webpack-5-chain 包的版本升级和修正,以及相关依赖包的版本更新。主要修复了 assetModuleFilename 方法的命名错误,并更新了作者的电子邮件地址。

Changes

文件路径 变更摘要
packages/bundler-webpack/compiled/webpack-5-chain/package.json 更新版本号从 8.0.18.0.2,修改作者的电子邮件地址。
packages/bundler-webpack/compiled/webpack-5-chain/types/index.d.ts 修正 assetModuleFilenamet 方法签名为 assetModuleFilename
packages/bundler-webpack/package.json 更新 webpack-5-chain 依赖版本从 8.0.18.0.2

Assessment against linked issues

Objective Addressed Explanation
修正配置命名空间中 assetModuleFilename 方法的错别字 (#12382)
修复设置静态文件夹方法的类型不准 (#11969)

Poem

在代码的森林中,
兔子轻轻跳跃,
修正了错别字,
版本号也更新,
静态文件夹的名字,
终于不再迷惑,
代码世界更美好。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fz6m fz6m merged commit 3b77b0b into umijs:master May 15, 2024
23 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f64d639 and 9751737.
Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
Files selected for processing (3)
  • packages/bundler-webpack/compiled/webpack-5-chain/package.json (1 hunks)
  • packages/bundler-webpack/compiled/webpack-5-chain/types/index.d.ts (1 hunks)
  • packages/bundler-webpack/package.json (1 hunks)
Files skipped from review due to trivial changes (3)
  • packages/bundler-webpack/compiled/webpack-5-chain/package.json
  • packages/bundler-webpack/compiled/webpack-5-chain/types/index.d.ts
  • packages/bundler-webpack/package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant