refactor: change route preonload inline to ref #12398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Walkthrough这些更改主要涉及在 Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Size Change: +241 B (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
|
感谢 PR！如果有兴趣一起参与维护 Umi，可加入我们的 Umi Contributor 群。加入方式是先用钉钉扫下方二维码加我钉钉，记得注明 github id，然后我会拉你到群里。 |
fz6m
reviewed
May 18, 2024
| @@ -306,6 +291,36 @@ export default (api: IApi) => { | |||
| .value() as any, | |||
| }; | |||
| } | |||
| if (api.name === 'build' && routeChunkFilesMap && !api.config.tern) { | |||
There was a problem hiding this comment.
api.name === 'build' && routeChunkFilesMap↑ 这个条件，在上面的代码也有，最好把它提取出来复用，比如叫 isEnableRoutePreload() 。
packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
Show resolved
Hide resolved
| join(api.paths.absOutputPath, `${PRELOAD_ROUTE_HELPER}${hashedPart}`), | ||
| content, | ||
| ), | ||
| 'utf-8'; |
There was a problem hiding this comment.
这是怎么漂移了。
在本地 commit 提交代码 → GitHub 发起 PR → CI 跑到绿色 这个流程中，建议一定要做两次代码检查：
-
第一次是改好了代码，在本地 commit 要编写 commit msg 前，先在 vscode 或者某些 git 可视化代码管理工具里，看一下你 change 部分的代码有没有问题，一定要浏览一遍，比如这个时候，那些明显的错误或者 console.log 等的遗留就可以避免。
-
第二次是在 GitHub 打开 PR 后，在 files 的 tab 里，再人工浏览过一遍代码，看看有没有上一次检查没发现的问题，同时再想一下，这个 PR 里的代码有没有 edge case ，有的话就再补充或修订，从而可以避免再返工的绝大多数问题。
在业务项目的代码里没必要做 2 次 check ，往往做 1 次本地 vscode git 可视化 change 浏览就可以了；你要提到 umi 仓库里的话，一定要谨慎再谨慎，本来 umi 的名声就不是特别好，不期望代码里漏洞百出被抓到把柄被黑，希望能逐渐提升锻炼到一次 PR 即成功，不存在明显的错误。
|
下次提 PR 的时候可以把自己的 GitHub id 加到根目录的 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
新功能
PRELOAD_ROUTE_HELPER常量以增强路由预加载功能。改进