Rename config parameters #96
Conversation
…, replace all config names in examples, update docu
There was a problem hiding this comment.
didn't test, but looks good.
i think making the heartbeat runtime configurable is debatable.
if we do this, it might be good to also make the heartbeat configurable on the rigs themselves (maybe we can send the timeout value in the rig start byte? pretty sure this would be possible - we just never thought about it before)
| @@ -15,7 +15,7 @@ | |||
| Value4: 1 | |||
|
|
|||
| Config: | |||
| TimerTime: 10 | |||
| PlotTimeout: 10 | |||
| InterpolationPoints: 0 | |||
| MovingWindowSize: 5 | |||
| MovingWindowEnable: True | |||
There was a problem hiding this comment.
the line below this needs to be changed to
HeartbeatTimeout: 100
|
|
||
| self.actHeartbeat = QAction("&Heartbeat Timeout", self) | ||
| self.optMenu.addAction(self.actHeartbeat) | ||
| self.actHeartbeat.triggered.connect(self.setHeartbeat) |
There was a problem hiding this comment.
not sure the heartbeat should be runtime configurable by user
There was a problem hiding this comment.
okay, I'm with you. Let us implement a self configuration routine. The question is, should we use a pre-hook before experiment start, or do it with first start as response to start flag on id1? I'm not sure, which makes more sense. Okay then the heatbeat is not configurable by user.
|
|
||
| self._settings.endGroup() | ||
|
|
||
| def setHeartbeat(self): |
see #89