-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when reloading model #450
base: master
Are you sure you want to change the base?
Conversation
I'm still getting the same crashes:
|
as this PR has not been merged yet (i haven't found the time), it is not wonder that it still crashes. |
Hi @umlaeute sorry I mean that I applied the patch locally, recompiled, and still got this crash. Please let me know if there's anything else I can do to help. |
I'm not getting the crash now built with the patch and with |
Found a bug while porting Gem over to plugdata, it also seems to affect the regular pure-data version of Gem.
When we stop rendering, we need to destroy the model data, because otherwise it will hold on to VBOs that are no longer valid after the openGL context is destroyed. This causes all examples that use models to crash if you close and re-open the window.