Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal device support for physio instrument #65

Open
ahmad11111111111 opened this issue Feb 20, 2024 · 13 comments
Open

universal device support for physio instrument #65

ahmad11111111111 opened this issue Feb 20, 2024 · 13 comments

Comments

@ahmad11111111111
Copy link
Collaborator

  • make label no longer assumed
  • add a read method from eeg_device
@ahmad11111111111
Copy link
Collaborator Author

hey kevin did these changes ever get pushed through

@ahmad11111111111
Copy link
Collaborator Author

I'm on the physio instrument and it doesn't look different.

@kevincar
Copy link
Member

If you're referring to pull request #66, then no. There are pending changes you need to make on your end before it's merged. You can see those reviews here

@ahmad11111111111
Copy link
Collaborator Author

its still saying i dont have write acess

@kevincar
Copy link
Member

You don't need it. You can simply commit changes to your fork and it will be reflected in the pull request.

@ahmad11111111111
Copy link
Collaborator Author

➜ libbci git:(develop) git push
ERROR: Write access to repository not granted.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
➜ libbci git:(develop) git pull
Already up to date.

@kevincar
Copy link
Member

What remote are you trying to push to?

@ahmad11111111111
Copy link
Collaborator Author

my bad i need to be in the fork

@ahmad11111111111
Copy link
Collaborator Author

i got it now

@ahmad11111111111
Copy link
Collaborator Author

wait. i never forked libbci

@kevincar
Copy link
Member

kevincar commented Feb 27, 2024

wait. i never forked libbci

I think you need to slow down a bit. This isn't the libbci repository. This is the libbids repository.

@ahmad11111111111
Copy link
Collaborator Author

got it

@ahmad11111111111
Copy link
Collaborator Author

i got them confused

@kevincar kevincar linked a pull request Feb 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants