Joystick #66
Joystick #66
Conversation
This should not be in the libbids package as there is no specified `joystick` modality
Non-descript changes to the test file
Not sure what this means? There are still comments you'll need to review. |
| @@ -7,13 +7,14 @@ | |||
| if TYPE_CHECKING: | |||
| from ..session import Session # type: ignore | |||
|
|
|||
|
|
|||
| #make label be defined after session variable | |||
There was a problem hiding this comment.
Can we remove this comment? This seems like a personal Todo
| @@ -43,7 +44,8 @@ def __init__( | |||
| preamp_filter : str | |||
| Optionally supplied preamp filter settings for saving into the data | |||
| of the edf file | |||
| init_read_fn : Union[Tuple[str, List, Dict], Callable] | |||
| init_read_fn :ead functions / joystcik device pysio instrument | |||
| eeg_instrument = EEGIns Union[Tuple[str, List, Dict], Callable] | |||
There was a problem hiding this comment.
I'm guessing this line was inserted by mistake?
There was a problem hiding this comment.
@ahmad11111111111 Was this changed?
|
i pushed the changes |
| @@ -43,7 +44,8 @@ def __init__( | |||
| preamp_filter : str | |||
| Optionally supplied preamp filter settings for saving into the data | |||
| of the edf file | |||
| init_read_fn : Union[Tuple[str, List, Dict], Callable] | |||
| init_read_fn :ead functions / joystcik device pysio instrument | |||
| eeg_instrument = EEGIns Union[Tuple[str, List, Dict], Callable] | |||
| init_read_fn: Union[Tuple[str, list, Dict], Callable] = lambda: None, | ||
| read_fn: Union[Tuple[str, list, Dict], Callable] = lambda: None, | ||
| **kwargs | ||
| init_read_fn :ead functions / joystcik device pysio instrument |
There was a problem hiding this comment.
This also seems to be an error.
|
ok give me a minute. i think i dug myself into a hole here. |
|
i think the rencent commits may have made things worse |
ahmad11111111111
force-pushed
the
joystick
branch
from
f509fa8 to
9a37412
Compare
|
I still have no idea what happened with the test subject file |
No worries. I had accidentally deleted it during the review process. You can either simply copy it from the repositories history, or I can add it in after the merge |
|
i think i got it. I think my brain is still melted a bit from all of those lab conduct courses |
|
Awesome. Just one more comment to resolve https://github.com/umnil/libbids/pull/66/files#r1495813483 |
-added read method and label is no longer assumed.