test: stick on Node v18.18

related privatenumber/tsx#354
un-ts · Dec 25, 2023 · a96fcfd · a96fcfd
1 parent c0996dd
commit a96fcfd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,6 +12,7 @@ jobs:
         node:
           - 16
           - 18
+          - 18.18
           - 20
         os:
           - macos-latest

diff --git a/test/helpers.ts b/test/helpers.ts
@@ -8,8 +8,8 @@ export const _dirname = path.dirname(fileURLToPath(import.meta.url))
 export const nodeVersion = Number.parseFloat(process.versions.node)
 
 export const tsUseEsmSupported =
-  nodeVersion >= MTS_SUPPORTED_NODE_VERSION &&
-  // ts-jest limitation
-  nodeVersion < 20
+  // https://github.com/privatenumber/tsx/issues/354
+  // eslint-disable-next-line @typescript-eslint/no-magic-numbers
+  nodeVersion >= MTS_SUPPORTED_NODE_VERSION && nodeVersion <= 18.18
 
 export const testIf = (condition: boolean) => (condition ? it : it.skip)
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,7 @@ jobs: @@
             node:
               - 16
               - 18
+              - 18.18
               - 20
             os:
               - macos-latest
@@ Expand Down @@