Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting, update deps to use sdk in dependencies #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

linting, update deps to use sdk in dependencies #48

wants to merge 3 commits into from

Conversation

simonmcho
Copy link
Contributor

  • Updated SDK to be used in dependencies
  • Linting

@brianpburns
Copy link
Contributor

I test out the sample-extension app and it loads but crashes when dragged into a page due to the openContainerLayout properties missing. I actually had opened a branch with very similar changes during Ship It Day if you want to copy what's there.

Some other minor things in that PR:

  • removing the .editorconfig files
  • removing the typings.d.ts files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonmcho @brianpburns