ci: add a lot of linting #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rei-x
commented
May 18, 2024
Comment on lines
20
to
35
| useEffect(() => { | ||
| localStorage.setItem('favorites', JSON.stringify(favorites)); | ||
| localStorage.setItem("favorites", JSON.stringify(favorites)); | ||
| }, [favorites]); | ||
|
|
||
| const handleFavorite = (book) => { | ||
| const handleFavorite = (book: Book_t) => { | ||
| setFavorites((prevFavorites) => { | ||
| const isAlreadyFavorite = prevFavorites.some(f => f.id === book.id); | ||
| const isAlreadyFavorite = prevFavorites.some( | ||
| (f: Book_t) => f.id === book.id, | ||
| ); | ||
| const updatedFavorites = isAlreadyFavorite | ||
| ? prevFavorites.filter(f => f.id !== book.id) | ||
| ? prevFavorites.filter((f: Book_t) => f.id !== book.id) | ||
| : [...prevFavorites, book]; | ||
| localStorage.setItem('favorites', JSON.stringify(updatedFavorites)); | ||
| localStorage.setItem("favorites", JSON.stringify(updatedFavorites)); | ||
| return updatedFavorites; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
po co jest ten useEffect na górze, skoro niżej wstawiasz rzeczy do local storage'u?
Rei-x
commented
May 18, 2024
Comment on lines
+26
to
+28
| const isAlreadyFavorite = prevFavorites.some( | ||
| (f: Book_t) => f.id === book.id, | ||
| ); |
There was a problem hiding this comment.
nie potrzebujesz tu adnotacji
Suggested change
| const isAlreadyFavorite = prevFavorites.some( | |
| (f: Book_t) => f.id === book.id, | |
| ); | |
| const isAlreadyFavorite = prevFavorites.some( | |
| (f) => f.id === book.id, | |
| ); |
Comment on lines
+12
to
15
| const handleFavoriteClick = (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| e.stopPropagation(); | ||
| handleFavorite(book); | ||
| }; |
There was a problem hiding this comment.
byś nie musiał tego typować jakbyś to wrzucił bezpośrednio koło buttona
<button
className={styles.favorite_container}
onClick={(e) => {
e.stopPropagation();
handleFavorite(book);
}}
>| import styles from "../styles/book.module.css"; | ||
| import type { BookProps } from "./appContext"; | ||
|
|
||
| const Book = React.memo(function Book({ |
There was a problem hiding this comment.
te memo i tak nie zadziała tutaj 😭, lepiej je wyrzucić
| export function toggleStringInList(string, list) { | ||
| const DELAY = 300; | ||
|
|
||
| export function toggleStringInList(string: string, list: string[]): string[] { |
There was a problem hiding this comment.
nie potrzebujesz tu typu
Suggested change
| export function toggleStringInList(string: string, list: string[]): string[] { | |
| export function toggleStringInList(string: string, list: string[]) { |
| <div> | ||
| {languages.map((clickedLanguage) => ( | ||
| <button | ||
| key={clickedLanguage} // Unique key prop added here |
| <Book | ||
| key={book.id} | ||
| book={book} | ||
| isFavorite={favorites.some((f: Book_t) => f.id === book.id)} |
There was a problem hiding this comment.
Suggested change
| isFavorite={favorites.some((f: Book_t) => f.id === book.id)} | |
| isFavorite={favorites.some((f) => f.id === book.id)} |
| /> | ||
| ))} | ||
| <div> | ||
| {favoriteBooks.map((book: Book_t) => ( |
There was a problem hiding this comment.
Suggested change
| {favoriteBooks.map((book: Book_t) => ( | |
| {favoriteBooks.map((book) => ( |
Comment on lines
+17
to
+21
| const savedFavoritesJSON = localStorage.getItem("favorites"); | ||
| const savedFavorites = | ||
| savedFavoritesJSON !== null | ||
| ? (JSON.parse(savedFavoritesJSON) as Book_t[]) | ||
| : []; |
There was a problem hiding this comment.
czemu ładujesz to na nowo skoro masz z props'ów tablice favorites? nie mogłeś jej użyć?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.