-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 微信小程序permission配置项缺少 #35
Conversation
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/core/src/config/types/mpWeixin.ts (1 hunks)
- packages/schema/schema.json (3 hunks)
Additional comments not posted (3)
packages/core/src/config/types/mpWeixin.ts (1)
200-200
: Approved: Expanded permission scope inMpWeixin
interface.The modification to the
permission
property correctly expands its scope to include'scope.userLocation'
,'scope.userLocationBackground'
, and'scope.userFuzzyLocation'
. This change aligns with the PR objectives and the linked issue.Please ensure that these new permissions are documented and tested thoroughly to confirm their integration with existing permissions and that they comply with WeChat's official documentation.
packages/schema/schema.json (2)
3261-3274
: Review ofscope.userLocationBackground
Permission AdditionThe addition of the
scope.userLocationBackground
permission is correctly implemented with the requireddesc
property. This property is essential for explaining the purpose of the permission to the user, which aligns with best practices for permission requests in applications.
Line range hint
3275-3288
: Review ofscope.userFuzzyLocation
Permission AdditionThe addition of the
scope.userFuzzyLocation
permission is correctly implemented. The structure includes adesc
property, which is mandatory and provides a description of the permission's use. This is crucial for transparency and user trust, especially for permissions related to location data.
Thank you. |
Description 描述
修复微信小程序permission配置项缺少
scope.userLocationBackground
和scope.userFuzzyLocation
的问题。相似的问题,在QQ小程序暂时没有发现,相关文档:QQ小程序scope授权注意事项
Linked Issues 关联的 Issues
fix #34
Additional context 额外上下文
附加微信的文档链接:
permission配置项
scope授权注意事项
Summary by CodeRabbit
New Features
Bug Fixes