Merge pull request #147 from unicef/feature/update-react-select

Fix required attribute in USelectPicker
unicef · Jan 12, 2024 · 566ea65 · 566ea65
2 parents 12f6b3c + 77ef633
commit 566ea65
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@unicef/material-ui",
-  "version": "0.12.1",
+  "version": "0.12.2",
   "description": "UNICEF theme and components of material-ui for react",
   "main": "index.js",
   "files": [

diff --git a/src/components/ActiveKeyboardDatePicker/ActiveKeyboardDatePicker.js b/src/components/ActiveKeyboardDatePicker/ActiveKeyboardDatePicker.js
@@ -70,6 +70,7 @@ export default function ActiveKeyboardDatePicker(props) {
     showLabelHelp,
     InputLabelHelpProps,
     label,
+    KeyboardButtonProps,
     ...others
   } = props
 
@@ -113,6 +114,7 @@ export default function ActiveKeyboardDatePicker(props) {
         }}
         readOnly={readOnly}
         KeyboardButtonProps={{
+          ...KeyboardButtonProps,
           classes: {
             root: `${!interactiveMode && !readOnly ? '' : hideIcon}`,
           },
@@ -170,11 +172,14 @@ ActiveKeyboardDatePicker.propTypes = {
   showLabelHelp: PropTypes.bool,
   /** Props applied to the input label help element. E.g InputLabelHelpProps={{type:'link', label:'Help', link:'unicef.github.io', icon, tooltipTitle: 'Tooltip title', tooltipPlacement: 'bottom}} */
   InputLabelHelpProps: PropTypes.object,
+  /** Keyboard button props */
+  KeyboardButtonProps: PropTypes.object,
 }
 
 ActiveKeyboardDatePicker.defaultProps = {
   inputVariant: 'outlined',
   autoOk: true,
   variant: 'inline',
   format: 'dd/MM/yyyy',
+  KeyboardButtonProps: {},
 }
diff --git a/src/components/ActiveKeyboardDateTimePicker/ActiveKeyboardDateTimePicker.js b/src/components/ActiveKeyboardDateTimePicker/ActiveKeyboardDateTimePicker.js
@@ -69,6 +69,7 @@ export default function ActiveKeyboardDateTimePicker(props) {
     showLabelHelp,
     InputLabelHelpProps,
     label,
+    KeyboardButtonProps,
     ...others
   } = props
 
@@ -112,6 +113,7 @@ export default function ActiveKeyboardDateTimePicker(props) {
         }}
         readOnly={readOnly}
         KeyboardButtonProps={{
+          ...KeyboardButtonProps,
           classes: {
             root: `${!interactiveMode && !readOnly ? '' : hideIcon}`,
           },
@@ -169,11 +171,14 @@ ActiveKeyboardDateTimePicker.propTypes = {
   showLabelHelp: PropTypes.bool,
   /** Props applied to the input label help element. E.g InputLabelHelpProps={{type:'link', label:'Help', link:'unicef.github.io', icon, tooltipTitle: 'Tooltip title', tooltipPlacement: 'bottom}} */
   InputLabelHelpProps: PropTypes.object,
+  /** Keyboard button props */
+  KeyboardButtonProps: PropTypes.object,
 }
 
 ActiveKeyboardDateTimePicker.defaultProps = {
   inputVariant: 'outlined',
   autoOk: true,
   variant: 'inline',
   format: 'dd/MM/yyyy hh:mm a',
+  KeyboardButtonProps: {},
 }
diff --git a/src/components/ActiveKeyboardTimePicker/ActiveKeyboardTimePicker.js b/src/components/ActiveKeyboardTimePicker/ActiveKeyboardTimePicker.js
@@ -68,6 +68,7 @@ export default function ActiveKeyboardTimePicker(props) {
     showLabelHelp,
     InputLabelHelpProps,
     label,
+    KeyboardButtonProps,
     ...others
   } = props
 
@@ -109,6 +110,7 @@ export default function ActiveKeyboardTimePicker(props) {
         }}
         readOnly={readOnly}
         KeyboardButtonProps={{
+          ...KeyboardButtonProps,
           classes: {
             root: `${!interactiveMode && !readOnly ? '' : hideIcon}`,
           },
@@ -162,10 +164,13 @@ ActiveKeyboardTimePicker.propTypes = {
   showLabelHelp: PropTypes.bool,
   /** Props applied to the input label help element. E.g InputLabelHelpProps={{type:'link', label:'Help', link:'unicef.github.io', icon, tooltipTitle: 'Tooltip title', tooltipPlacement: 'bottom}} */
   InputLabelHelpProps: PropTypes.object,
+  /** Keyboard button props */
+  KeyboardButtonProps: PropTypes.object,
 }
 
 ActiveKeyboardTimePicker.defaultProps = {
   inputVariant: 'outlined',
   autoOk: true,
   variant: 'inline',
+  KeyboardButtonProps: {},
 }
diff --git a/src/components/USelectPicker/Input.js b/src/components/USelectPicker/Input.js
@@ -14,7 +14,15 @@ export default function Input(props) {
         : undefined
   }
 
-  return <components.Input {...props} aria-describedby={describedBy} />
+  return (
+    <components.Input
+      {...props}
+      aria-describedby={describedBy}
+      required={
+        (props && props.selectProps && props.selectProps.required) || undefined
+      }
+    />
+  )
 }
 
 Input.propTypes = {

diff --git a/src/components/USelectPicker/InputComponent.js b/src/components/USelectPicker/InputComponent.js
@@ -2,7 +2,14 @@ import React from 'react'
 import PropTypes from 'prop-types'
 
 export default function InputComponent({ inputRef, ...props }) {
-  return <div ref={inputRef} {...props} />
+  return (
+    <div
+      ref={inputRef}
+      {...props}
+      required={undefined} // Remove required from div element
+      aria-invalid={undefined} // Remove aria-invalid from div element
+    />
+  )
 }
 
 InputComponent.propTypes = {