Cpp executor - first collation conformance tests with ICU4C #106
Conversation
|
I think this needs to explicitly reference the particular JSON library. Running ./executor gives with any input gives: |
|
Yikes, some of my Schema stuff has leaked into this. |
executors/cpp/Makefile
Outdated
| # export ICU4C= $location | ||
| # export LD_LIBRARY_PATH=$ICU4C/lib:$LD_LIBRARY_PATH | ||
| # export PATH=$ICU4C/bin:$PATH | ||
| # export CPATH=$ICU4C/bin:$CPATH | ||
| # - do 'make' in this directory | ||
|
|
There was a problem hiding this comment.
I don't see json-c mentioned anywhere; seems like it should be?
There was a problem hiding this comment.
If it's installed properly, then an explicit reference isn't needed.
|
Updated this PR with ICU4C collation versions 71, 72, 73, and 74. |
There was a problem hiding this comment.
If you pull out the ICU4C number formatting code, it looks good to me. Save any rework you need to do on ICU4C number formatting executor code for a separate PR. I can help you with git stuff to split your code out into separate branches accordingly if that's what you want to do.
sven-oly
changed the title
|
Many of the comments that you replied to don't have the changes applied in the PR. Did you make the commits locally without pushing them? Check Sublime Merge to visually see what's going on. |
|
|
||
| // What was the actual returned value? | ||
| json_object_object_add( | ||
| return_json, "compare", json_object_new_int64(numeric_result)); |
There was a problem hiding this comment.
yay, looking good (by using numeric_result as the arg to json_object_new_int64)
executors/test_strings.txt
Outdated
There was a problem hiding this comment.
Thanks for updating this file accordingly.
This adds files for compiling and executing C++ with ICU4C in conformance testing. This is not yet ready for integration.