Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump smallvec version to 1.0 #46

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Bump smallvec version to 1.0 #46

merged 1 commit into from
Nov 9, 2019

Conversation

messense
Copy link
Contributor

@messense messense commented Nov 9, 2019

See servo/rust-smallvec#175 for changelog

@Manishearth Manishearth merged commit 56a1477 into unicode-rs:master Nov 9, 2019
@SimonSapin SimonSapin mentioned this pull request Nov 25, 2019
Closed
@nox nox mentioned this pull request Dec 9, 2019
Closed
@SimonSapin
Copy link
Contributor

The smallvec MSRV update moved to MaybeUninit which crates should be doing as soon as possible to avoid potential UB

Note that https://crates.io/crates/smallvec/0.6.13 uses https://crates.io/crates/maybe_uninit which uses std::mem::MaybeUninit on 1.36+, so it should be as sound as https://crates.io/crates/smallvec/1.0.0.

@Manishearth
Copy link
Member

@SimonSapin that seems to rely on cfg(native_uninit), which afaict is not set on newer compilers? You have to set that yourself.

@Manishearth
Copy link
Member

Oh, I see.

@SimonSapin
Copy link
Contributor

That cfg is set by a build script based on parsing rustc --version https://github.com/est31/maybe-uninit/blob/v2.0.0/build.rs#L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@messense @SimonSapin @Manishearth @mathstuf