Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Update README.md #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

samuelsayag
Copy link

Update to what is really displayed
In the test code there was an error == instead of === ...made me search a few minutes

@netlify
Copy link

netlify bot commented Jul 15, 2021

👷 Deploy request for unisonweb-org pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 286e21a

@samuelsayag
Copy link
Author

Change following the experience I had with the longer tutorial...

Copy link
Collaborator

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samuelsayag — I left some comments

src/data/docs/tour/README.md Outdated Show resolved Hide resolved
@@ -284,7 +284,7 @@ square x = x * x

use test

test> square.tests.ex1 = check (square 4 == 16)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check (square 4 == 16) ought to work, so let's get to the bottom of that before updating the docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ucm UI that opens show in the package base then test that the operator === and not == exist...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@samuelsayag
Copy link
Author

@aryairani I can close the pull request. It was just a matter of signalling what did not worked for me. If you take care of it, it is not problem :)

@samuelsayag
Copy link
Author

@aryairani reversed what was not wanted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants