Update the service implementation to not require knowledge of a speci…

…fic class-based resource implementation (#55)

* Update the service implementation to not require knowledge of a specific class-based resource implementation

* Add dep

reactiveweb/src/resource/service.ts

@@ -11,8 +11,6 @@ import {
   macroCondition,
 } from '@embroider/macros';
 
-import { Resource } from 'ember-resources';
-
 import type Owner from '@ember/owner';
 import type { Stage1DecoratorDescriptor } from '#types';
 
@@ -167,17 +165,12 @@ export function service(resource: unknown) {
             cache = invokeHelper(owner, resource);
             caches.set(resource, cache);
             associateDestroyableChild(owner, cache);
-          } else if ((resource as any).prototype instanceof Resource) {
-            assert(
-              `The .from() method on a type of Resource has been removed or altered. This is not allowed.`,
-              'from' in resource && resource.from === Resource.from
-            );
-
+          } else if ('from' in resource) {
             /**
              * We do a lot of lying internally to make TypeScript nice for consumers.
              * But it does mean that we have to cast in our own code.
              */
-            let { definition } = (resource as typeof Resource).from(() => []) as unknown as any;
+            let { definition } = (resource as any).from(() => []) as unknown as any;
 
             cache = invokeHelper(owner, definition);
             caches.set(resource, cache);

tests/min-supported/package.json

@@ -99,6 +99,7 @@
     "@ember/test-waiters": "^3.1.0",
     "@nullvoxpopuli/eslint-configs": "^3.2.2",
     "ember-concurrency": "^3.1.1",
+    "ember-modify-based-class-resource": "^1.1.0",
     "ember-resources": "^6.5.1",
     "msw": "^1.3.2"
   },

tests/test-app/package.json

@@ -101,6 +101,7 @@
     "@embroider/macros": "^1.13.4",
     "@nullvoxpopuli/eslint-configs": "^3.2.2",
     "ember-concurrency": "^3.1.1",
+    "ember-modify-based-class-resource": "^1.1.0",
     "ember-resources": "^6.5.1",
     "msw": "^1.3.2"
   },

tests/test-app/tests/resources/service-test.gts

@@ -3,7 +3,8 @@ import { find,render } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
 
-import { cell, Resource, resource } from 'ember-resources';
+import { Resource } from 'ember-modify-based-class-resource';
+import { cell, resource } from 'ember-resources';
 import { service, serviceOverride } from 'reactiveweb/resource/service';
 // This export is marked as @internal, so it is not present in
 // the built d.ts files.