Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request with some new features and improvements #4

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

hablutzel1
Copy link

Some notes on the proposed changeset:

  • Commit messages are still referencing issues created on https://github.com/hablutzel1/cryptoapplet/issues, what would be the best thing to do here?, to include full links?, to migrate these issues?, to take them out of the commit messages?
  • New 'uji-dist' Maven module is currently creating a distribution only for PDF signature, but I could change it to allow to configure the desired distribution by using Maven profiles (e.g. for CMS signature or a combination of several formats).
  • There are long comments inline in the code explaining some code snippets, maybe it is not up to your coding standards, just let me know and I can take that out before the pull request gets applied.

I'll keep awaiting for your comments on this pull request to improve what is required.

@borillo
Copy link
Member

borillo commented Jun 4, 2015

Hi @hablutzel1 :)

It would be great if you can migrate the issues here. I just activated the issue section a few days ago.

It will be difficult to review the whole pull-request with all the modifications mixed togeher, but i will try to discuss each point here in order to complete de integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants