Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to zgenom #88

Merged
merged 23 commits into from
Mar 27, 2021
Merged

Switch to zgenom #88

merged 23 commits into from
Mar 27, 2021

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Nov 13, 2020

Switch to zgenom instead of zgen.

zgen has been great, but it also hasn't seen any merges to master since 2018.

Fortunately @jandamm has created a new fork of zgen, zgenom, which they are actively developing. In addition to getting ongoing maintenance, it has new features like lazy loading and .zshrc compilation that should help with the speed issues (#15) some people are seeing. It also supports plugins that do not use a branch named master as the default repository branch.

jandamm has been careful to maintain compatibility with zgen in command names and invocations, so it's almost a drop in replacement. I've been running off this branch for weeks without issues, so I'm ready to flip the switch.

1. `cd ~`
2. `git clone git@github.com:tarjoilija/zgen.git`
2. `git clone https://github.com/jandamm/zgenom.git`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation for list items at the same level

Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Nov 13, 2020

Code Climate has analyzed commit 2989c91 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2

View more on Code Climate.

@unixorn unixorn mentioned this pull request Nov 13, 2020
@unixorn unixorn force-pushed the switch-to-zgenom branch 3 times, most recently from 2c97f13 to f47b6af Compare November 14, 2020 04:31
@jandamm
Copy link

jandamm commented Nov 22, 2020

Hi @unixorn,
I'm updating the api of zgenom a little bit.
It'll be possible to use zgenom instead of zgen and ohmyzsh instead of oh-my-zsh. The readme is also updated accordingly.
I'm finishing things up and would merge it when you're ready with this PR.

@unixorn
Copy link
Owner Author

unixorn commented Nov 24, 2020

@jandamm If you're updating the api, go ahead merge jandamm/zgenom#25 into zgenom and tag here when you're done and I'll update this PR accordingly.

I still need to make this PR warn existing users and not just upgrade out from under them. And when they do upgrade, I want them to get the latest greatest zgenom :-)

@jandamm
Copy link

jandamm commented Nov 24, 2020

Done 👍

@jandamm
Copy link

jandamm commented Mar 8, 2021

Hey @unixorn, is there anything I can do to help making progress on this PR?

@unixorn unixorn changed the title WIP: Switch to zgenom Switch to zgenom Mar 27, 2021
@unixorn
Copy link
Owner Author

unixorn commented Mar 27, 2021

@jandamm Sorry I let this get dropped - I was busy with other things and lost track of it. Merging.

@unixorn unixorn merged commit 06c3460 into master Mar 27, 2021
@unixorn unixorn deleted the switch-to-zgenom branch April 27, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants