Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export type helpers #58

Merged
merged 6 commits into from
Nov 15, 2023
Merged

feat: export type helpers #58

merged 6 commits into from
Nov 15, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#23696

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This exports type helpers matching the functions/return types of the helpers scule offers.

Ideally this should mean if #57 lands, we can just update the implementation of these types rather than have a breaking change.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Oct 23, 2023
@danielroe danielroe requested a review from pi0 October 23, 2023 14:02
@danielroe danielroe self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (21f19ba) 100.00% compared to head (210f720) 100.00%.
Report is 3 commits behind head on main.

❗ Current head 210f720 differs from pull request most recent head 3e4cd49. Consider uploading reports for the commit 3e4cd49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #58    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1         2     +1     
  Lines          131       338   +207     
  Branches        35        36     +1     
==========================================
+ Hits           131       338   +207     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 October 24, 2023 00:48
@pi0 pi0 merged commit a83e505 into main Nov 15, 2023
1 check passed
@pi0 pi0 deleted the feat/export-types branch November 15, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants