Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pascalCase, camelCase): lower rest of each segment #62

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 15, 2023

πŸ”— Linked issue

Resolves #53

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

For PascalCase and camelCase (which depends in Pascal util), we were splitting but then preserving cases of each segment which could be upper or lower.

Before: FOO_BAR => pascal: FOOBAR camel: fOOBAR
After: FOO_BAR => pascal: FooBar camel: fooBar

This has small regression but i think right fix for the utils.

Note: This new behavior be behind a flag in next patch releases ~> #63

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe November 15, 2023 17:34
@pi0 pi0 merged commit 3815767 into main Nov 15, 2023
1 check passed
@pi0 pi0 deleted the fix/split branch November 15, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camelCase result for all uppercase strings
2 participants