Fixed search pagination #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checked, too lazy to setup Docker to run locally
|
Thanks for the PR! Unfortunately, to add a load more functionality, we'll have to modify our redis server to have this capability. @knightron0 will look into this; thanks for bringing this to our attention! |
|
yeah^ the redis query has an upper bound to it. it does allow pagination though – so we can just query it again whenever the the load more button is clicked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Load More and Load All UI buttons to load more courses into the search page. I didn't want to setup the Docker on my laptop so y'all might need to edit the UI.