Fetch CurseForge API key from official files #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-goode
force-pushed
the
evan-goode/curseforge
branch
from
51caceb to
e8c39f8
Compare
Instead of fetching the CurseForge API key from PolyMC's server, fetch it from the files of the CurseForge app, mirrored by archive.org. We can do this without downloading the entire 100MiB+ application by range-requesting the specific DEFLATE block where the key is and decompressing just that block.
evan-goode
force-pushed
the
evan-goode/curseforge
branch
from
e8c39f8 to
810ab86
Compare
|
When running from GUI no contents appear in the Curseforge instance creation menu, when ran from a CLI getting access denied from Curseforge with this key, the older key pulled from PolyMC works fine still |
|
Well that was difficult, but I think it's fixed now. It's now downloading the same key as served by PolyMC. |
|
Works for me, tried importing a few curseforge modpack they all worked, removed the key, it revoked access, added it back with the menu button and it regained access so seems working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of fetching the CurseForge API key from PolyMC's server, fetch it from the files of the CurseForge app, mirrored by archive.org. We can do this without downloading the entire 100MiB+ application by range-requesting the specific DEFLATE block where the key is and decompressing just that block.