Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the appropriate changes to make Legacy clients authenticate properly when a custom server is selected #26

Closed
wants to merge 1 commit into from

Conversation

Midou36O
Copy link

The commit effectively rewrites portions of the onlinefix java classes to support custom domains through flags, and adds the flags when a custom auth account is being used. This allows the legacy minecraft java versions to be able to pull skins and join (I did not test however) servers.
Also switches OnlineFixes from the default false to true

…rly when a custom server is selected

Signed-off-by: Midou36O <[email protected]>
@evan-goode
Copy link
Member

Oh did you see my branch https://github.com/unmojang/FjordLauncher/tree/evan-goode/legacy? I linked to it in one of the Matrix rooms but did not open a PR yet, so it was not that visible, sorry.

Your patchset looks like it does the job also, but I made some additional changes to get it working with any authlib-injector API server, not just Drasl. Fjord must also support Ely.by, Blessing SKin, etc. The authlib-injector spec is notably missing /game/joinserver.jsp, and https://wiki.vg/Mojang_API#Username_to_UUID, so we have to work around that.

@Midou36O
Copy link
Author

Midou36O commented Aug 20, 2024

Oh whoops, I didn't see that branch at all, i thought it was just some sort of theory and no actual code was written yet, my bad.

Yeah I mostly focused on mojang auth, but looks like you're always 2 steps ahead than me 😄
I'll close this PR in favor of the legacy branch work then, will make sure to make reviews once the PR is available.

@Midou36O Midou36O closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants