fix: Revert type=module change

[timphillips]

The changes in #341 introduced an issue with importing RavelinJS via the npm package (reported in this internal Slack thread).

The default import (e.g. import Ravelin from 'ravelinjs/core') now returns undefined instead of the expected Ravelin constructor function. Ravelin is instead being initialised as a global variable.

The format of the bundles published in v1.8.0 are identical to v1.7.1. It appears that the "type": "module" change in package.json impacts how the package is imported in build systems. This reverts the change until we determine the magical combination of config options required for a proper fix.

#344 was also reverted because it depends on #341 (though I've preserved the change to target IE11 in tests).

[ericmatteucci]

LGTM! Thanks for this

[talon266]

LGTM
I think we need to determine what's a module and what's commonjs and perhaps split it into 2 projects?
https://nodejs.org/api/packages.html#type

[icio]

Bah, apologies for this. I think the part I forgot to update was:

ravelinjs/rollup.config.js

Lines 65 to 69 in 177bcbf

	file: 'dist/' + basename(bundle),
	format: 'umd',
	name: 'Ravelin',
	esModule: false,
	exports: 'default',

This should probably be:

   file: 'dist/' + basename(bundle),
-  format: 'umd',
-  name: 'Ravelin',
-  esModule: false,
-  exports: 'default',
+  format: 'es',

However, it's potentially going to be a nuisance getting require and import to work in a backwards-compatible manner when switching to modules. require isn't technically supported by ESModules. The switch to ESModules could just be part of the v2 branch in #345 so that we don't need to worry about supporting both styles.

[icio]

Some good links here on the matter: https://deno.com/blog/commonjs-is-hurting-javascript.

Anyway, peace ✌️ Hope to see you all soon.