Initial configuration #1
Conversation
kaessert
force-pushed
the
tk/initial-config
branch
2 times, most recently
from
027b102 to
0ae6a92
Compare
|
/test-examples |
|
/test-examples |
3 similar comments
|
/test-examples |
|
/test-examples |
|
/test-examples |
|
/test-examples |
1 similar comment
|
/test-examples |
kaessert
force-pushed
the
tk/initial-config
branch
from
06e9f83 to
57e2939
Compare
|
/test-examples |
|
/test-examples |
1 similar comment
|
/test-examples |
kaessert
force-pushed
the
tk/initial-config
branch
from
57e2939 to
3ff879b
Compare
|
/test-examples |
kaessert
force-pushed
the
tk/initial-config
branch
2 times, most recently
from
4f43bde to
e4e8ba6
Compare
|
/test-examples |
1 similar comment
|
/test-examples |
| @@ -0,0 +1,5 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
why we need this ? is foreground deletion not enough ?
There was a problem hiding this comment.
Because uptest runs always with --wait=false
https://github.com/crossplane/uptest/blob/main/internal/templates/03-delete.yaml.tmpl#L23
There was a problem hiding this comment.
Mhm i don't like the fact that we have extra shell scripts around for this
There was a problem hiding this comment.
wonder how this workes before in platform-ref-aws - pre 1.0 uptest ?
There was a problem hiding this comment.
Neither do i :) What i tried to is to extend uptest to manipulate the wait-parameter but even then it failed because even though it waited for the delete of the XR, the usage was still lingering around making it fail.
There was a problem hiding this comment.
Damn, i tried it again with the older version but there the import step fails with some i think kuttl-related stuff and i don't see a way to skip the import in the older version
uptest-v0.13.0: error: unknown long flag '--skip-import'
There was a problem hiding this comment.
We tried several things, none of them seem reasonable at this point. Please check crossplane/uptest#33 for futher details.
kaessert
force-pushed
the
tk/initial-config
branch
from
e4e8ba6 to
e3e31a3
Compare
kaessert
force-pushed
the
tk/initial-config
branch
from
e3e31a3 to
902f263
Compare
|
/test-examples |
There was a problem hiding this comment.
2024/10/15 11:54:11 === STDOUT
2024/10/15 11:54:11 internetgateway.ec2.aws.upbound.io/configuration-aws-lb-controller-q459v condition met
2024/10/15 11:54:11 subnet.ec2.aws.upbound.io/configuration-aws-lb-controller-g48tp condition met
2024/10/15 11:54:11 subnet.ec2.aws.upbound.io/configuration-aws-lb-controller-zzzbh condition met
2024/10/15 11:54:11 vpc.ec2.aws.upbound.io/configuration-aws-lb-controller-vz9nd condition met
2024/10/15 11:54:11 cluster.eks.aws.upbound.io/configuration-aws-lb-controller-ctffw condition met
2024/10/15 11:54:11 | 11:54:11 | delete | Assert Deletion | SCRIPT | DONE |
2024/10/15 11:54:11 | 11:54:11 | delete | Assert Deletion | TRY | DONE |
2024/10/15 11:54:11 --- PASS: chainsaw (0.00s)
2024/10/15 11:54:11 --- PASS: chainsaw/delete (701.51s)
2024/10/15 11:54:11 PASS
2024/10/15 11:54:11 Tests Summary...
2024/10/15 11:54:11 - Passed test 1
2024/10/15 11:54:11 - Failed tests 0
2024/10/15 11:54:11 - Skipped tests 0
2024/10/15 11:54:11 Done.
11:54:11 [ OK ] running automated tests
The test run is green, including clean deletion 👍
I left a couple of suggestions inline.
kaessert
force-pushed
the
tk/initial-config
branch
2 times, most recently
from
0006e00 to
5610ada
Compare
kaessert
force-pushed
the
tk/initial-config
branch
from
5610ada to
bebfbe1
Compare
|
/test-examples |
Initial configuration for aws-lb-controller
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
make e2eand manual verification