checkpoint checkin #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
reviewed
Oct 30, 2023
.up/config/datadog-xm/Dockerfile
Outdated
| @@ -0,0 +1,7 @@ | |||
| FROM gcr.io/datadoghq/agent:latest | |||
There was a problem hiding this comment.
can we switch Dockerfiles and files to cluster/images//*
like: https://github.com/crossplane-contrib/x-metrics/tree/main/cluster/images/x-metrics
and please add the following section in makefile:
https://github.com/crossplane-contrib/x-metrics/blob/main/Makefile#L47-L54
then the docker build process is used from upbound build module
| echo_info "Building and Loading Datadog XMetrics Agent with Upbound integration" | ||
| CWD=$(pwd) | ||
| cd ${SCRIPT_DIR}/../.up/config/datadog-xm | ||
| docker build -t datadog-upbound_xmetrics:v1.0.0 . |
There was a problem hiding this comment.
we can skip the build when using the build process from build module
…workflows via PR comments Signed-off-by: Fatih Türken <[email protected]>
[xmetrics-integration] Prevent external contributors from triggering workflows via PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added the following tested items to this checkpoint check in.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested