Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate major version v2 #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tomassatka
Copy link

Description of your changes

Since provider-vault is already beyond v2.0.0 it has to follow versioning principles for golang: https://go.dev/blog/v2-go-modules

Otherwise it causes issue when trying to use a go.mod dependency

When i first try to fetch it as dependency i get:

tomas@Tomass-MacBook-Pro svcs % go mod tidy
go: errors parsing go.mod:
go.mod:9:2: require github.com/upbound/provider-vault: version "v2.0.1" invalid: should be v0 or v1, not v2

That is confirmed by listing it:

tomas@Tomass-MacBook-Pro svcs % go list -m -versions github.com/upbound/provider-vault

github.com/upbound/provider-vault v0.1.0 v0.2.0 v0.3.0 v0.4.0 v1.0.0

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Executed all major make commands successfuly

@Upbound-CLA
Copy link

Upbound-CLA commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@tomassatka tomassatka force-pushed the main branch 3 times, most recently from 0c91de3 to fb31861 Compare February 3, 2025 09:40
Signed-off-by: Tomas Satka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants