-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom tags and handlers #2
Open
andregoncalvesdev
wants to merge
1
commit into
master
Choose a base branch
from
feature/add-custom-tags-handlers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -18,13 +18,39 @@ class TopperWebSdk { | |||
environment: Environments.PRODUCTION, | |||
is_android_app: false, | |||
is_ios_app: false, | |||
use_assets: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or make this an array ['assets']
, default to []
and append on 116 accordingly.
andregoncalvesdev
force-pushed
the
feature/add-custom-tags-handlers
branch
from
January 22, 2024 21:28
1c8469d
to
05a5189
Compare
WIDGET_CONTINUE_BUTTON_CLICKED = 'widgetContinueButtonClicked' | ||
WIDGET_CONTINUE_BUTTON_CLICKED = 'widgetContinueButtonClicked', | ||
// Internal | ||
RESOLVE_HANDLER = 'resolveHandler' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to another enum.
andregoncalvesdev
force-pushed
the
feature/add-topper-web-sdk
branch
from
January 22, 2024 21:37
e15b5f1
to
8462d00
Compare
andregoncalvesdev
force-pushed
the
feature/add-custom-tags-handlers
branch
from
January 22, 2024 21:39
05a5189
to
397d1dd
Compare
andregoncalvesdev
force-pushed
the
feature/add-custom-tags-handlers
branch
from
January 26, 2024 16:56
397d1dd
to
931cf0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWY-1436
Integration wrapper
Topper
assets.mov