replace {httr} with {curl}

[jameslamb]

fixes #229

• replaces {httr} with {curl}
• adds some integration tests covering HTTP-request code (that don't rely on Elasticsearch)

Notes for Reviewers

How I tested this

The existing integration tests cover all the Elasticsearch interactions.

To check that the retry logic works, I built the package from source and installed it.

cd r-pkg/
R CMD INSTALL .

Then, in R:

futile.logger::flog.threshold(futile.logger::DEBUG)

# request that should succeed
res <- uptasticsearch:::.request(
    verb = "GET"
    , url = "https://httpbin.org/status/429"
    , body = NULL
    , add_json_headers = FALSE
)

Saw logs like this:

DEBUG [2025-02-22 23:07:40] Request failed (status code 429): 'GET https://httpbin.org/status/429'
DEBUG [2025-02-22 23:07:40] Sleeping for 1.88 before retrying.
DEBUG [2025-02-22 23:07:42] Request failed (status code 429): 'GET https://httpbin.org/status/429'
DEBUG [2025-02-22 23:07:42] Sleeping for 2.62 before retrying.
DEBUG [2025-02-22 23:07:45] Request failed (status code 429): 'GET https://httpbin.org/status/429'

And a response object returned:

res$method
# [1] "GET"

res$status_code
# [1] 429

res$url
# [1] "https://httpbin.org/status/429"

[jameslamb]

Turns out we didn't need any of this stuff!!!

I realized through this exercise that the difference across Elasticsearch versions was like this:

• we weren't passing the Accept header in this request to GET /_cat/aliases
• on ES 1.x and 2.x, GET /_cat/aliases responded with fixed-width text by default
• from ES 3.x onwards, it responded with JSON data by default
• across ALL versions, it responds with JSON data if you pass Accept: application/json

So just passing that header, this now always returns JSON and no more need for these different processing functions 😁 😁 😁

[austin3dickey]

Amazing!

[austin3dickey]

Looks great!

[austin3dickey]

Amazing!

[austin3dickey]

Cool!

[austin3dickey]

I forget, does one of the other integration tests use a body? If not maybe we should add one just for a lil more coverage

[jameslamb]

Many do use it implicitly... for example es_search() is going to issue a POST request with the query attached as a body.

But agree it'd be good to have an explicit one here, to cover that if() block. I'll add that before merging.

[jameslamb]

Just pushed 51ee836 with 2 more tests, explicitly covering the case where requests have a body.

[jameslamb]

Those new tests are passing, R CMD check looks happy... onwards, to CRAN!!

Thanks as always @austin3dickey