Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] reduce duplication in scripts, clean up containers #251

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

jameslamb
Copy link
Collaborator

Contributes to #90

This proposes some miscellaneous cleanup to testing and development scripts.

  • reduces duplication in test-integration.R
  • passes --rm to all docker run calls, to clean up containers when they exit

Notes for reviewers

After a few weeks of active development here, I have a bunch of stranded containers.

docker container ls --all
image

These take up a little storage space, and are just noise when you're looking for other containers. Adding --rm to every docekr run ensures that they automatically get cleaned up when the containers exit.

@jameslamb jameslamb added the maintenance miscellaneous maintenance label Feb 24, 2025
@jameslamb jameslamb marked this pull request as ready for review February 24, 2025 03:22
@jameslamb jameslamb merged commit 39739dd into uptake:main Feb 24, 2025
15 checks passed
@jameslamb jameslamb deleted the misc-dev branch February 24, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance miscellaneous maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant