-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add first draft of nomeclature converters #10
Open
MrtinoRG
wants to merge
15
commits into
main
Choose a base branch
from
converters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fa30e39
feat: add first draft of nomeclature converters
MrtinoRG b45f8c1
feat: add unit-tests
MrtinoRG b3eb05b
fix: solve gitignore file
MrtinoRG e6853c9
Update src/chemenv/tools/converters.py
MrtinoRG 931681b
feat: implement converters in the modal app
MrtinoRG cbcf142
fix: solve problems for deployment
MrtinoRG 152a83c
chore: enhance logging
MrtinoRG ae61e9f
chore: move images and imports
MrtinoRG ba4ec8b
fix: correct format of the converters output
MrtinoRG d1eb174
fix: remove unknown api
MrtinoRG e7518c9
feat: add inverse functions
MrtinoRG 15cfca7
Update tests/tools/test_converters.py
MrtinoRG 6365350
fix: apply suggestion from code review + improve Exception management
MrtinoRG 26f6ec5
Merge branch 'converters' of github.com:ur-whitelab/chem-env into con…
MrtinoRG 3df5571
chore: improve doc-strings
MrtinoRG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the reason for making all of them semantically private (leading
_
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is that most of the functions of the app are called the same as the working functions, or they were at some point