Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in WorkConditionsMonitor when going in and out of aeroplane mode #420

Closed
simonwhitehouse opened this issue Jan 29, 2025 · 5 comments
Closed

Comments

@simonwhitehouse
Copy link

Updated to the latest version of the SDK 19.0.0
Getting a crash when turning aeroplane mode on and off in WorkConditionsMonitor.

Task { [conditionsSubject] in for await _ in await networkMonitor.connectionUpdates { conditionsSubject.send() } }

Have attached a screenshot of the crash

Image
@rlepinski
Copy link
Contributor

Was able to reproduce and have a fix in review. Thanks for the report.

@rlepinski
Copy link
Contributor

I pushed the code and tagged it, but the build is going to fail due to this issue - actions/runner-images#11504

If its not resolved tomorrow we will look into manually deploying the release without github actions. If you are using SPM on this repo it should be fine

@rlepinski
Copy link
Contributor

Published pods, so the only thing that wont work is prebuild carthage or the prebuilt SPM package. I am going to give it another day before I manually deploy that part.

@rlepinski
Copy link
Contributor

To deploy the xcframeworks and prebuilt spm we have to sign the packages. I would rather not sign those manually so I am going to cross my fingers and hope the github issue is resolved next week so we can go back to our normal releases process. Pods and SPM are out for 19.0.1 and ill have a release for 19.0.2 for the other issue reported here soon with the same terrible partial release process.

@simonwhitehouse
Copy link
Author

We are using SPM so yeah have updated to use 19.0.1 and the fix seems to be working, thanks for jumping on it so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants