Feature bots yaml #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see this as part of this extension. I would rather prefer a hook in which you can execute a script and return a string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while using your extension for a client, we had a feature request to add more Bot patterns to the regex, for example the ones from the official matomo List (https://raw.githubusercontent.com/matomo-org/device-detector/master/regexes/bots.yml)
This PR the Bot.yaml and a script to create a single usable Regex String (see Scripts/README.md), which will be used like the current Regex string. Thus the performance inpact is kept to a minimum (< 1.2ms in testing).