Lagoon jets for IEEE 754 floats. #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current root problem is that https://github.com/urbit/vere/actions/runs/8819670490/job/24211443275?pr=638 Adding them piecemeal seems to be a fool's errand: any way to just build the whole thing at one go for each? I.e. include all files rather than manually listing the subset of interest? |
|
There seem to be some platform-specific optimized versions linked in as well, so this may need to stay in the same vein to be effectively fast. |
|
@urbit/kernel this is building now thanks to @pkova's sleuthing. |
|
This is ready for review. |
|
When the tests pass here on that last commit, then this is ready to merge. @joemfb @pkova @belisarius222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to draft UIP at https://github.com/urbit/UIPs/blob/sigilante/lagoon-reals/UIPS.
Should be released alongside corresponding Hoon code.