Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2047: Searchbox no longer a component, turn off sdc #2057

Closed
wants to merge 1 commit into from

Conversation

DaleMHFrey
Copy link
Contributor

In order to turn off the SDC module [before upgrading to 10.3] we just need to make our one-and-only component a non-component.

https://cm-jira.usa.gov/browse/USAGOV-2047

Description

Made the searchblock a non-component. And pushed the setting to uninstall the SDC module.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Switch to this branch. Run bin/drush cr and then bin/drush cim. Confirm the SDC module is turned off. And to test; Go to the front-page (or any page) and confirm the page is not crashing [over trying to render the search-box].

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@DaleMHFrey
Copy link
Contributor Author

Closing this ticket as we are going to take an alternative strategy for resolving this requirement.

@DaleMHFrey DaleMHFrey closed this Nov 7, 2024
@DaleMHFrey DaleMHFrey deleted the USAGOV-2047 branch November 7, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant