Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1533: Check whether tome is running #2073

Closed
wants to merge 3 commits into from
Closed

Conversation

DaleMHFrey
Copy link
Contributor

@DaleMHFrey DaleMHFrey commented Nov 13, 2024

When we check whether tome is running, can we check tome-static instead of tome-run?

https://cm-jira.usa.gov/browse/USAGOV-1533

Description

When a user loads the page at https://localhost/static-site-status the script will now confirm whether Tome is disabled before reporting the Tome status. In the event the flag that indicates that Tome is still running yet Tome is disabled, the flag gets reset.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

  • Pull in the latest database
  • set Tome to be disabled
  • go to https://localhost/static-site-status
  • Expect to see a message saying that Tome is not allowed to run
  • Additionally if you start Tome, kill it (before it can report that it is done running), disable it, and then go to https://localhost/static-site-status again. The script is smart enough to reset the flag that indicates tome is running.

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, this isn't actually the problem I was trying to solve with this ticket. I realize now that the description was entirely unclear.

I also have reservations about the clause starting on line 25, although I haven't tested this to be sure I'm reading it correctly. If someone disables static site generation while tome is already running, it will complete the current run. So it's perfectly reasonable to have tome running and disabled at the same time.

@akf
Copy link
Member

akf commented Nov 21, 2024

I'm going to close this PR without merging. Sorry again about the confusion!

@akf akf closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants