Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2050-Cypress-Github-Actions: Github Actions Files #2076

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

IsabelLaurenceau
Copy link
Collaborator

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2050

Description

  • Add github action workflow files for regression testing stage and production static sites (https://beta-stage.usa.gov/ & https://usa.gov/).
  • The reason there are two extremely similar files "stage-a11y-regression-tests.yml & prod-a11y-regression-tests.yml" is because we change the CYPRESS_BASE_URL environment variable between the two. We aren't actually running against the code we are running against the static sites so we can't make use of the environment flag github actions has.
  • If we had only one workflow file with two different jobs for the environments we would need to run both jobs each time. We don't want to run prod on a stage regression test day and vice-versa so two workflows are needed.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • This can't really be tested until deployed to the main branch (that's when the Github Action will appear) but for an idea of what this will do see this repo where I worked on this. ( I didn't want to spam the team while doing this work so I made a separate repo to only spam myself)
  • You should be able to go to the actions tab and select either "Stage A11Y Regression Tests" or "Prod A11Y Regression Tests" from the left menu.
  • A "Run workflow" button will be on that page. If you click it and refresh the page you will see the regression test start. It should take about 3min and 30seconds.
  • I've noticed we have a few new failing tests but these actually need the tests to be updated not the Github action which will be done in a new ticket.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@IsabelLaurenceau IsabelLaurenceau marked this pull request as ready for review November 15, 2024 15:22
@cwacht cwacht merged commit 39c4246 into dev Nov 19, 2024
5 of 6 checks passed
@cwacht cwacht deleted the USAGOV-2050-Cypress-Github-Actions branch November 19, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants