Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2092-Failing-Cypress-Tests: #2077

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

IsabelLaurenceau
Copy link
Collaborator

@IsabelLaurenceau IsabelLaurenceau commented Nov 18, 2024

update tests for stage and prod

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2092

Description

We had some hard-coded urls in our tests that work locally but break when testing against stage and prod. These update those tests to check for the environment and set the urls accordingly.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@IsabelLaurenceau IsabelLaurenceau marked this pull request as ready for review November 18, 2024 20:41
@cwacht cwacht requested review from cwacht and removed request for cwacht November 19, 2024 20:32
@cwacht cwacht self-requested a review November 19, 2024 21:11
Copy link
Contributor

@cwacht cwacht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running both tests I see that everything is passing on Stage but the footer is failing on Prod. Checking the logs I can confirm that the URLs fixed by this pull request are passing. The items that are failing are simply due to the template changes from USAGOV-2028 not being on Prod yet, but they should pass after tonights Prod deployment.

So this pull request is good to go.

Here are the tests:
Stage Prod

@cwacht cwacht merged commit 743a6d0 into dev Nov 19, 2024
6 of 8 checks passed
@cwacht cwacht deleted the USAGOV-2092-Failing-Cypress-Tests branch November 19, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants