Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2095-menu-block-cache #2081

Merged
merged 3 commits into from
Nov 21, 2024
Merged

USAGOV-2095-menu-block-cache #2081

merged 3 commits into from
Nov 21, 2024

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Nov 19, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2095

Description

: Add the menu being rendered to the cache tags for menu blocks.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Repeat for Spanish.

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

On local, ensure render and twig caching is enabled

  1. Edit the English left menu item, move an item to a different order under its parent
  2. In an incognito window, load the parent page and confirm the moved item is in the correct position.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@omerida omerida changed the title USAGOC-2095-menu-block-cache USAGOV-2095-menu-block-cache Nov 19, 2024
@akf akf self-assigned this Nov 21, 2024
Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@akf
Copy link
Member

akf commented Nov 21, 2024

Just FYI, I ran the code scans and the things it flagged are unrelated to this PR.

@akf akf merged commit e06c930 into dev Nov 21, 2024
6 of 7 checks passed
@akf akf deleted the USAGOV-2095-menu-block-cache branch November 21, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants