Merge branch 'main' into feat/frontend/online-status/avatar

backend/src/auth/auth.controller.ts

@@ -1,6 +1,7 @@
 import {
   Body,
   Controller,
+  Delete,
   Get,
   HttpCode,
   Post,
@@ -16,14 +17,14 @@ import {
   ApiTags,
 } from '@nestjs/swagger';
 import type { User } from '@prisma/client';
+import { Response } from 'express';
 import { CurrentUser } from 'src/common/decorators/current-user.decorator';
 import { AuthService } from './auth.service';
 import { LoginDto } from './dto/login.dto';
 import { TwoFactorAuthenticationDto } from './dto/twoFactorAuthentication.dto';
 import { TwoFactorAuthenticationEnableDto } from './dto/twoFactorAuthenticationEnable.dto';
 import { AuthEntity } from './entity/auth.entity';
-import { JwtGuardWithout2FA } from './jwt-auth.guard';
-import { Response } from 'express';
+import { JwtAuthGuard, JwtGuardWithout2FA } from './jwt-auth.guard';
 
 const constants = {
   loginUrl: ((): string => {
@@ -121,4 +122,13 @@ export class AuthController {
   ) {
     return this.authService.twoFactorAuthenticate(dto, user.id);
   }
+
+  @Delete('2fa/disable')
+  @HttpCode(200)
+  @UseGuards(JwtAuthGuard)
+  @ApiBearerAuth()
+  @ApiOkResponse()
+  async disable2FA(@CurrentUser() user: User) {
+    return this.authService.disableTwoFactorAuthentication(user.id);
+  }
 }

backend/src/auth/auth.service.ts

@@ -224,6 +224,21 @@ export class AuthService {
     });
   }
 
+  disableTwoFactorAuthentication(userId: number) {
+    return this.prisma.$transaction(async (prisma) => {
+      const user = await prisma.user.findUnique({ where: { id: userId } });
+      if (!user.twoFactorEnabled) {
+        throw new ConflictException('2FA secret is not enabled');
+      }
+      await prisma.user.update({
+        where: { id: user.id },
+        data: {
+          twoFactorEnabled: false,
+        },
+      });
+    });
+  }
+
   async twoFactorAuthenticate(dto: TwoFactorAuthenticationDto, userId: number) {
     const user = await this.prisma.user.findUnique({ where: { id: userId } });
     if (!user.twoFactorEnabled) {

backend/src/chat/chat.gateway.ts

@@ -10,15 +10,15 @@ import {
 import { Server, Socket } from 'socket.io';
 import { RoomDeletedEvent } from 'src/common/events/room-deleted.event';
 import { RoomEnteredEvent } from 'src/common/events/room-entered.event';
+import { RoomLeftEvent } from 'src/common/events/room-left.event';
 import { RoomMuteEvent } from 'src/common/events/room-mute.event';
 import { RoomUnmuteEvent } from 'src/common/events/room-unmute.event';
-import { RoomLeftEvent } from 'src/common/events/room-left.event';
 import { RoomUpdateRoleEvent } from 'src/common/events/room-update-role.event';
-import { ChatService, UserStatus } from './chat.service';
 import { MuteService } from 'src/room/mute/mute.service';
+import { v4 } from 'uuid';
+import { ChatService, UserStatus } from './chat.service';
 import { CreateMessageDto } from './dto/create-message.dto';
 import { MessageEntity } from './entities/message.entity';
-import { v4 } from 'uuid';
 
 @WebSocketGateway({
   cors: {

backend/src/chat/chat.module.ts

@@ -1,7 +1,7 @@
 import { Module } from '@nestjs/common';
 import { AuthModule } from 'src/auth/auth.module';
-import { MuteService } from 'src/room/mute/mute.service';
 import { PrismaModule } from 'src/prisma/prisma.module';
+import { MuteService } from 'src/room/mute/mute.service';
 import { UserService } from '../user/user.service';
 import { ChatController } from './chat.controller';
 import { ChatGateway } from './chat.gateway';

backend/src/room/guards/enter-room.guard.ts

@@ -5,8 +5,8 @@ import {
   ForbiddenException,
   Injectable,
 } from '@nestjs/common';
-import { RoomService } from '../room.service';
 import { compare } from 'bcrypt';
+import { RoomService } from '../room.service';
 
 @Injectable()
 export class EnterRoomGuard implements CanActivate {

backend/src/room/mute/mute.controller.ts

@@ -1,17 +1,17 @@
 import {
-  Controller,
-  Get,
-  Put,
   Body,
+  Controller,
   Delete,
+  Get,
   Param,
   ParseIntPipe,
+  Put,
   UseGuards,
 } from '@nestjs/common';
-import { CreateMuteDto } from './dto/create-mute.dto';
 import { ApiBearerAuth, ApiTags } from '@nestjs/swagger';
 import { JwtAuthGuard } from 'src/auth/jwt-auth.guard';
 import { AdminGuard } from '../guards/admin.guard';
+import { CreateMuteDto } from './dto/create-mute.dto';
 import { MuteService } from './mute.service';
 
 @ApiTags('mute')

backend/src/room/mute/mute.module.ts

@@ -1,7 +1,7 @@
 import { Module } from '@nestjs/common';
 import { PrismaModule } from 'src/prisma/prisma.module';
-import { MuteService } from './mute.service';
 import { MuteController } from './mute.controller';
+import { MuteService } from './mute.service';
 
 @Module({
   controllers: [MuteController],

backend/src/room/mute/mute.service.ts

@@ -4,11 +4,11 @@ import {
   Injectable,
   NotFoundException,
 } from '@nestjs/common';
-import { CreateMuteDto } from './dto/create-mute.dto';
 import { EventEmitter2 } from '@nestjs/event-emitter';
 import { RoomMuteEvent } from 'src/common/events/room-mute.event';
 import { RoomUnmuteEvent } from 'src/common/events/room-unmute.event';
 import { PrismaService } from 'src/prisma/prisma.service';
+import { CreateMuteDto } from './dto/create-mute.dto';
 
 @Injectable()
 export class MuteService {

backend/src/room/room.service.ts

@@ -5,6 +5,7 @@ import {
 } from '@nestjs/common';
 import { EventEmitter2 } from '@nestjs/event-emitter';
 import { Role, User } from '@prisma/client';
+import { hash } from 'bcrypt';
 import { RoomCreatedEvent } from 'src/common/events/room-created.event';
 import { RoomDeletedEvent } from 'src/common/events/room-deleted.event';
 import { RoomEnteredEvent } from 'src/common/events/room-entered.event';
@@ -16,7 +17,6 @@ import { UpdateUserOnRoomDto } from './dto/update-UserOnRoom.dto';
 import { UpdateRoomDto } from './dto/update-room.dto';
 import { UserOnRoomEntity } from './entities/UserOnRoom.entity';
 import { RoomEntity } from './entities/room.entity';
-import { hash } from 'bcrypt';
 
 @Injectable()
 export class RoomService {

backend/test/auth.e2e-spec.ts

@@ -77,5 +77,16 @@ describe('AuthController (e2e)', () => {
     it('[GET /user/me] should return 200 if 2FA is enabled and code is provided', async () => {
       await app.getMe(user.accessToken).expect(200);
     });
+
+    it('[DELETE /auth/2fa/disable] should disable 2FA', async () => {
+      await app.disableTwoFactorAuthentication(user.accessToken).expect(200);
+    });
+
+    it('[POST /auth/2fa/enable] should re-enable 2FA', async () => {
+      const code = authenticator.generate(secret);
+      await app
+        .enableTwoFactorAuthentication(code, user.accessToken)
+        .expect(200);
+    });
   });
 });

backend/test/chat-gateway.e2e-spec.ts

@@ -1,12 +1,12 @@
-import { Role } from '@prisma/client';
 import { INestApplication } from '@nestjs/common';
 import { Test, TestingModule } from '@nestjs/testing';
+import { Role } from '@prisma/client';
 import { Socket, io } from 'socket.io-client';
 import { AppModule } from 'src/app.module';
 import { MessageEntity } from 'src/chat/entities/message.entity';
+import { CreateRoomDto } from 'src/room/dto/create-room.dto';
 import { constants } from './constants';
 import { TestApp, UserEntityWithAccessToken } from './utils/app';
-import { CreateRoomDto } from 'src/room/dto/create-room.dto';
 
 async function createNestApp(): Promise<INestApplication> {
   const moduleFixture: TestingModule = await Test.createTestingModule({

backend/test/online-status.e2e-spec.ts

@@ -2,9 +2,9 @@ import { INestApplication } from '@nestjs/common';
 import { Test, TestingModule } from '@nestjs/testing';
 import { Socket, io } from 'socket.io-client';
 import { AppModule } from 'src/app.module';
+import { UserStatus } from 'src/chat/chat.service';
 import { TestApp, UserEntityWithAccessToken } from './utils/app';
 import { expectOnlineStatusResponse } from './utils/matcher';
-import { UserStatus } from 'src/chat/chat.service';
 
 type UserAndSocket = {
   user: UserEntityWithAccessToken;

backend/test/utils/app.ts

@@ -29,6 +29,11 @@ export class TestApp {
       .set('Authorization', `Bearer ${accessToken}`)
       .send({ code });
 
+  disableTwoFactorAuthentication = (accessToken: string) =>
+    request(this.app.getHttpServer())
+      .delete('/auth/2fa/disable')
+      .set('Authorization', `Bearer ${accessToken}`);
+
   twoFactorAuthenticate = (code: string, accessToken: string) =>
     request(this.app.getHttpServer())
       .post('/auth/2fa/authenticate')

frontend/app/explore-rooms/explore-rooms.tsx

@@ -1,10 +1,10 @@
 "use client";
 
-import RoomCard from "./room-card";
-import { useCallback, useEffect } from "react";
-import { useRouter } from "next/navigation";
 import { DeleteRoomEvent, RoomEntity } from "@/app/lib/dtos";
 import { chatSocket as socket } from "@/socket";
+import { useRouter } from "next/navigation";
+import { useCallback, useEffect } from "react";
+import RoomCard from "./room-card";
 
 export function ExploreRooms({ rooms }: { rooms: RoomEntity[] }) {
   const router = useRouter();

frontend/app/lib/actions.ts

@@ -106,21 +106,30 @@ export async function updateUser(
   prevState: string | undefined,
   formData: FormData,
 ) {
-  const { user_id, ...updateData } = Object.fromEntries(formData.entries());
-  const res = await fetch(`${process.env.API_URL}/user/${user_id}`, {
+  const userId = await getCurrentUserId();
+  const newNickname = formData.get("name");
+  const newEmail = formData.get("email");
+  const res = await fetch(`${process.env.API_URL}/user/${userId}`, {
     method: "PATCH",
     headers: {
       "Content-Type": "application/json",
       Authorization: "Bearer " + getAccessToken(),
     },
-    body: JSON.stringify(updateData),
+    body: JSON.stringify({ name: newNickname, email: newEmail }),
   });
   const data = await res.json();
+  if (res.status === 401) {
+    redirect("/login");
+  } else if (res.status === 409) {
+    console.error("updateUser error: ", data);
+    return "The name or email is already in use";
+  }
   if (!res.ok) {
-    return "Error";
+    console.error("updateUser error: ", data);
+    return data.message;
   } else {
     revalidatePath("/user");
-    revalidatePath(`/user/${user_id}`);
+    revalidatePath(`/user/${userId}`);
     return "Success";
   }
 }

frontend/app/lib/client-socket-provider.tsx

@@ -1,9 +1,10 @@
 "use client";
 import { ToastAction } from "@/components/ui/toast";
 import { useToast } from "@/components/ui/use-toast";
-import { chatSocket } from "@/socket";
+import { chatSocket, chatSocket as socket } from "@/socket";
 import Link from "next/link";
-import { useCallback, useEffect } from "react";
+import { usePathname, useRouter } from "next/navigation";
+import { useEffect } from "react";
 import { useAuthContext } from "./client-auth";
 import {
   DenyEvent,
@@ -12,9 +13,6 @@ import {
   MessageEvent,
   PublicUserEntity,
 } from "./dtos";
-import { chatSocket as socket } from "@/socket";
-import { useRouter } from "next/navigation";
-import { usePathname } from "next/navigation";
 
 export default function SocketProvider() {
   const { toast } = useToast();

frontend/app/lib/hooks/useInviteToGame.ts

@@ -1,7 +1,7 @@
 "use client";
 
-import { useCallback, useState } from "react";
 import { chatSocket as socket } from "@/socket";
+import { useCallback, useState } from "react";
 
 export const useInviteToGame = (userId: number) => {
   const [isInvitingToGame, setIsInvitingToGame] = useState(false);

frontend/app/lib/hooks/useKick.ts

@@ -1,12 +1,11 @@
 "use client";
 
 import { kickUserOnRoom } from "@/app/lib/actions";
-import type { LeaveRoomEvent, UserOnRoomEntity } from "@/app/lib/dtos";
+import type { LeaveRoomEvent } from "@/app/lib/dtos";
 import { toast } from "@/components/ui/use-toast";
-import { useCallback, useEffect, useState } from "react";
-import { useRouter } from "next/navigation";
 import { chatSocket as socket } from "@/socket";
-import { usePathname } from "next/navigation";
+import { usePathname, useRouter } from "next/navigation";
+import { useCallback, useEffect, useState } from "react";
 
 const showKickErrorToast = () => {
   toast({

frontend/app/lib/hooks/useMute.ts

@@ -3,8 +3,8 @@
 import { muteUser, unmuteUser } from "@/app/lib/actions";
 import type { PublicUserEntity } from "@/app/lib/dtos";
 import { toast } from "@/components/ui/use-toast";
-import { useCallback, useEffect, useState } from "react";
 import { chatSocket as socket } from "@/socket";
+import { useCallback, useEffect, useState } from "react";
 
 interface MuteEvent {
   userId: number;

frontend/app/lib/hooks/useOnlineStatus.ts

@@ -1,7 +1,7 @@
 "use client";
 
-import { createContext, useEffect, useState } from "react";
 import { chatSocket } from "@/socket";
+import { createContext, useEffect, useState } from "react";
 
 export const OnlineContext = createContext<{ [key: number]: number }>({});
 

frontend/app/lib/hooks/useUpdateRole.ts

@@ -3,8 +3,8 @@
 import { updateRoomUser } from "@/app/lib/actions";
 import type { UserOnRoomEntity } from "@/app/lib/dtos";
 import { toast } from "@/components/ui/use-toast";
-import { useCallback, useEffect, useState } from "react";
 import { chatSocket as socket } from "@/socket";
+import { useCallback, useEffect, useState } from "react";
 
 type Role = "ADMINISTRATOR" | "MEMBER";
 

frontend/app/onlineProviders.tsx

@@ -1,7 +1,7 @@
 "use client";
 
-import { OnlineContext, useOnlineStatus } from "./lib/hooks/useOnlineStatus";
 import SocketProvider from "./lib/client-socket-provider";
+import { OnlineContext, useOnlineStatus } from "./lib/hooks/useOnlineStatus";
 
 export function OnlineProviders({ children }: { children: React.ReactNode }) {
   const onlineStatus = useOnlineStatus();

frontend/app/pong/JoinRoomForm.tsx

@@ -10,12 +10,12 @@ import {
 } from "@/components/ui/card";
 import { Input } from "@/components/ui/input";
 import { Label } from "@/components/ui/label";
+import { Separator } from "@/components/ui/separator";
 import Link from "next/link";
 import { useRouter } from "next/navigation";
 import { useState } from "react";
-import MatchButton from "./MatchButton";
 import { v4 } from "uuid";
-import { Separator } from "@/components/ui/separator";
+import MatchButton from "./MatchButton";
 
 export default function JoinRoomForm({}) {
   return (

frontend/app/room/[id]/mute-menu.tsx

@@ -1,13 +1,11 @@
 "use client";
 
-import { muteUser, unmuteUser } from "@/app/lib/actions";
 import {
   ContextMenuItem,
   ContextMenuSub,
   ContextMenuSubContent,
   ContextMenuSubTrigger,
 } from "@/components/ui/context-menu";
-import { useState } from "react";
 
 export default function MuteMenu({
   isMuted,