[backend] invite to play #224

kotto5 · 2024-01-21T16:20:24Z

test を追加しました
chat namespace にevent を追加しました
- invite-pong (誰かをinviteする)
- invite-cancel-pong (invite した人が invite をキャンセルする)
- approve-pong (invite を受理する) (invite してきていない相手のことは approve を送っても試合開始されない)
- match-pong (approve すると、両者に当イベントでroomId が送られる)
block しているされている user には invite 出来ない. ( server 側で制御 )
web socket を使うテストでは、綺麗に書けたんじゃないかなって思います!
エラー時 (approve ) にクライアントにエラーメッセージを送信

TODO

frontend側
deny-pong
message と name space は分けなくていいのか?
- 分けてない状態でエラーメッセージを送ろうとすると、'error' イベントが被る可能性がある。

coderabbitai · 2024-01-21T16:20:31Z

Walkthrough

The recent updates involve enhancing a chat application to support an invite pong game feature. The backend now handles new WebSocket messages for inviting and approving participants in this game. A unique ID generation functionality has been added for message tracking, and the chat service has been expanded to manage invitations through a mapping system. Additionally, comprehensive end-to-end tests have been implemented to ensure the feature works correctly, including the setup of WebSocket connections and various invitation scenarios.

Changes

File Path	Change Summary
`.../src/chat/chat.gateway.ts`	Added message handling methods for invite and approve pong; imported `v4` from 'uuid' for unique ID generation.
`.../src/chat/chat.service.ts`	Expanded service with invite management and related methods.
`.../test/chat-gateway.e2e-spec.ts`	Introduced tests for invite pong game feature and WebSocket setup.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

backend/src/chat/chat.gateway.ts

backend/test/chat-gateway.e2e-spec.ts

getUsersBlockedBy method in ChatService

…approve user, user will receive error-pong event

backend/src/chat/chat.service.ts

lim396 · 2024-01-23T18:46:45Z

backend/test/chat-gateway.e2e-spec.ts

+            }, 500),
+          ));
+      });
+      describe('invite -> cancel -> invite', () => {


このテストをするのであれば、cancelを挟まずにinvite -> inviteのケースもあるとより良いと思います。

lim396 · 2024-01-23T18:54:14Z

backend/src/chat/chat.service.ts


  getUser(client: Socket) {
    return this.users.get(client.id);
  }

+  getWsFromUserId(userId: number): Socket | undefined {


ほぼ同じような機能の関数なのでgetUserかgetWsFromUserIdのどちらかにフォーマット合わせた方が良いかも？

フォーマット?
返り値の型を無くすみたいな話ですか？

lim396 · 2024-01-23T18:58:23Z

backend/test/chat-gateway.e2e-spec.ts

+    let userAndSockets: UserAndSocket[];
+
+    beforeAll(() => {
+      const users = [user1, user2, mutedUser1, kickedUser1];


kickedUser1は使っていなさそうです。

kotto5 added 3 commits January 21, 2024 22:17

[backend] Add invitePong event handler to ChatGateway

c25fad6

[backend] change to kebab case from camel case

fe74356

[backend] Add approve-pong event handler to ChatGateway

f9f6934

coderabbitai bot reviewed Jan 21, 2024

View reviewed changes

backend/src/chat/chat.gateway.ts Outdated Show resolved Hide resolved

backend/src/chat/chat.gateway.ts Outdated Show resolved Hide resolved

backend/test/chat-gateway.e2e-spec.ts Outdated Show resolved Hide resolved

backend/test/chat-gateway.e2e-spec.ts Outdated Show resolved Hide resolved

kotto5 added 10 commits January 22, 2024 23:20

[backend] To isolate each test, webSocket reconnect in afterEach

3b92b9e

[backend] Refactor chat-gateway.e2e-spec.ts

1f2f1d8

[backend] Add invite-cancel-pong event handling

e26c762

[backend] Add test case for approve-pong event

bdc734c

[backend] Add test case for blocking user invite

d1bf431

[backend] Remove user invite when client disconnects

91e78ca

[backend] Fix blocking logic in ChatGateway and add

8c31bbe

getUsersBlockedBy method in ChatService

[backend] if user send approve-pong message to user who don't invite …

7003f87

…approve user, user will receive error-pong event

[backend] rename test name.

3de90b4

[backend] Fix error in ChatGateway emit

a6f50e7

kotto5 merged commit 3dadae2 into main Jan 23, 2024
4 checks passed

kotto5 deleted the feat/frontend/chat/invite-pong branch January 23, 2024 00:56

kotto5 linked an issue Jan 23, 2024 that may be closed by this pull request

invite to play #228

Closed

lim396 reviewed Jan 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[backend] invite to play #224

[backend] invite to play #224

kotto5 commented Jan 21, 2024 •

edited

Loading

coderabbitai bot commented Jan 21, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

lim396 Jan 23, 2024

lim396 Jan 23, 2024

kotto5 Feb 1, 2024

lim396 Jan 23, 2024

[backend] invite to play #224

[backend] invite to play #224

Conversation

kotto5 commented Jan 21, 2024 • edited Loading

coderabbitai bot commented Jan 21, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

lim396 Jan 23, 2024

Choose a reason for hiding this comment

lim396 Jan 23, 2024

Choose a reason for hiding this comment

kotto5 Feb 1, 2024

Choose a reason for hiding this comment

lim396 Jan 23, 2024

Choose a reason for hiding this comment

kotto5 commented Jan 21, 2024 •

edited

Loading

coderabbitai bot commented Jan 21, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)