[backend] online status

[kotto5]

• test 追加
• chat namespace に connect しているかどうかで online 判定

TODO

• login 直後に chat namespace に登録されていると思い利用したがfrontend でそうなっているか確認する

[coderabbitai]

Walkthrough

The recent updates involve enhancing the chat feature by refocusing the online status functionality. The isOnline method has been shifted from the ChatService to the ChatController, introducing a new endpoint to check if a user is online. Additionally, the testing suite has been expanded to cover online status checks, now accommodating scenarios involving multiple users and sockets, ensuring a more robust and reliable chat service.

Changes

Files	Change Summary
backend/src/chat/chat.controller.ts	Moved isOnline to ChatController as isUserOnline.
backend/src/chat/chat.service.ts	Removed isOnline method.
backend/test/chat-gateway.e2e-spec.ts, .../utils/app.ts	Added tests for online status with support for multiple users/sockets.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[usatie]

これいちいちAPIで確認する必要があるならwsで繋がってる旨みがない気がするんですが、ちゃんと動きます？
多分これの原因になってる気がする
#238

[usatie]

オンラインステータスの表示はwsで新しく接続したユーザー、接続を切ったユーザーがどんどん流れてくる仕組みにしないといけないかと！

[kotto5]

そういう実装の方が良い みたいなのは分かるんですが、API で実装する方法に何か問題はあるのでしょうか?

[kotto5]

オンライン状態かどうかはリアルタイムに受け取れないと駄目だよね〜と話しました

• polling
• ws (全体ユーザ取得)
• ws (変化ユーザ取得)
  のやり方がある