[frontend] display pending status #233

lim396 · 2024-01-30T06:53:55Z

chat channelのcontext menu内のボタンを一度押したら処理が終了するまで再度押せないように修正しました。
BAN、ADD USERも同様に修正し、処理中はpending状態の表示をするように変更しました。
エラーが発生した際のユーザーへの通知や処理の修正、モーダルウィンドウ周りの修正(特にBAN)は別PRで行います。

…ess completes

coderabbitai · 2024-01-30T06:54:53Z

Walkthrough

The recent update introduces a suite of features aimed at enhancing user moderation within chat rooms. This includes the ability to mute or ban users with new UI components, such as MuteMenu, BanItem, and UnbanItem, facilitating more granular control over user interactions. Additionally, improvements in state management and async operations in existing components like sidebar-item underscore a broader effort to refine the application's responsiveness and user experience.

Changes

File Path	Change Summary
`frontend/app/room/[id]/mute-menu.tsx`	Adds `MuteMenu` component for muting users with duration options.
`frontend/app/room/[id]/sidebar-item.tsx`	Enhances state management, introduces `MuteMenu`, and updates async functions.
`frontend/app/ui/room/ban-item.tsx` & `frontend/app/ui/room/unban-item.tsx`	Implements `BanItem` and `UnbanItem` components for banning and unbanning users, respectively.
`frontend/app/ui/room/ban-modal.tsx` & `frontend/app/ui/room/invite-modal.tsx`	Refactors to use `BanItem`/`UnbanItem` and `InviteItem` components, removing direct calls to actions.
`frontend/app/ui/room/invite-item.tsx`	Introduces `InviteItem` for inviting users with loading indicator.
`frontend/components/ui/context-menu.tsx`	Modifies `className` in `ContextMenuSubContent` for styling and animation.
`frontend/components/ui/loader.tsx`	Adds `Loader` component for loading animations with optional styling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

frontend/app/ui/room/ban-item.tsx

frontend/app/ui/room/invite-item.tsx

frontend/app/ui/room/unban-item.tsx

usatie · 2024-01-30T18:14:42Z

frontend/app/room/[id]/sidebar-item.tsx

+    isClicked: false,
+  });
+  const [isUpdateRoleClicked, setIsUpdateRoleClicked] = useState(false);
+


なーんかこのたくさんstateを作らないといけないのって嫌ですね〜w
useBlock() useInvite useMute useUpdateRoleとかで関心ごとに分けてほしいかもな〜。

例えばですが、こんな感じでuseBlockを設計してみるとか。

const { block, unblock, pending, isBlocked } = useBlock(); ... <ContextMenuItem disabled={isBlocked || pending} onSelect={block} > Block </ContextMenuItem> <ContextMenuItem disabled={!isBlocked || pending} onSelect={unblock} > Unblock </ContextMenuItem>

useFormStatusとか、既存にあるものをいろいろ参考にしてみるといいかもしれません。
命名、設計, etc...
https://react.dev/reference/react-dom/hooks/useFormStatus

usatie · 2024-01-30T18:21:27Z

frontend/app/room/[id]/sidebar-item.tsx

    socket.emit("invite-pong", { userId: user.userId });
-    setIsInviting(true);
+    setInviteState({ isInviting: true, isClicked: false });
  };


inviteがどんな挙動のものなのか、知らないな。どういうものなんだろうこれ

このファイルはchat-roomに関して書かれているので、単にinviteだと、そのchatにinviteするみたいだから紛らわしいかも。

usatie · 2024-01-30T18:28:54Z

frontend/app/ui/room/ban-item.tsx

+  const router = useRouter();
+  const [isClicked, setIsClicked] = useState(false);
+
+  const onBan = async (userId: number) => {


onBanという名前がよく分かりません。onXXXというのはXXXが起きた時に行われるactionというイメージかと。
例えばonClickだったら、clickされたときに実行されるアクションという感じです。

あと、そもそもなんでuserIdを引数に取らないといけないですか？user.idでいいから必要なさそうな気がするんだけど

lim396 added 3 commits January 30, 2024 15:13

[frontend] Fixed animation when closing sub menu of context menu

656be72

[frontend] Add pending status display to Ban and Add User

cd26f1f

[frontend] Button in context menu now disables after click until proc…

565751b

…ess completes

coderabbitai bot reviewed Jan 30, 2024

View reviewed changes

[frontend] Fixes around buttons in modal windows(tmp)

8371c5e

lim396 force-pushed the feat/frontend/display-pending-status branch from aa058a5 to 8371c5e Compare January 30, 2024 07:27

lim396 merged commit 4a6d6d5 into main Jan 30, 2024
4 checks passed

lim396 deleted the feat/frontend/display-pending-status branch January 30, 2024 07:48

usatie reviewed Jan 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[frontend] display pending status #233

[frontend] display pending status #233

lim396 commented Jan 30, 2024 •

edited

Loading

coderabbitai bot commented Jan 30, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

usatie Jan 30, 2024

usatie Jan 30, 2024

usatie Jan 30, 2024

usatie Jan 30, 2024

usatie Jan 30, 2024

[frontend] display pending status #233

[frontend] display pending status #233

Conversation

lim396 commented Jan 30, 2024 • edited Loading

coderabbitai bot commented Jan 30, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

usatie Jan 30, 2024

Choose a reason for hiding this comment

usatie Jan 30, 2024

Choose a reason for hiding this comment

usatie Jan 30, 2024

Choose a reason for hiding this comment

usatie Jan 30, 2024

Choose a reason for hiding this comment

usatie Jan 30, 2024

Choose a reason for hiding this comment

lim396 commented Jan 30, 2024 •

edited

Loading

coderabbitai bot commented Jan 30, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)