Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Notify user of errors in actions within the chat channel #234

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

lim396
Copy link
Collaborator

@lim396 lim396 commented Jan 30, 2024

  • BlockやKick、Add userなどchat channel内でのアクションでエラーが発生した際にユーザーにトーストで通知するように変更しました。
  • Banの管理画面でユーザー一覧にownerが入ってしまっていたので除外しました。(ownerはBan出来ないため)

40C832E5-490A-424A-AF0B-FA41A5862D75_1_105_c

Copy link
Contributor

coderabbitai bot commented Jan 30, 2024

Walkthrough

The recent updates across various frontend components focus on enhancing user feedback during error scenarios. Instead of halting operations with exceptions, the system now returns a more graceful "Error" message or displays error toasts for actions like updating room users, kicking users, and managing bans or invites. These changes aim to improve user experience by providing clear feedback during failures, directly affecting the room management and user interaction features within the application.

Changes

File(s) Change Summary
frontend/app/lib/actions.ts Replaced throw new Error with return "Error" for updateRoomUser and kickUserOnRoom actions.
.../room/[id]/sidebar-item.tsx Added error toast notifications for failed user actions like kick, mute, unmute, block, and role updates.
.../room/[id]/sidebar-menu.tsx Removed members variable in favor of directly using usersOnRoom; added usersOnRoom prop to InviteUser component.
.../ui/room/ban-item.tsx Added showBanErrorToast function to display an error toast upon ban failure.
.../ui/room/ban-modal.tsx Added usersOnRoom prop to exclude room owner from unbanned users list.
.../ui/room/invite-item.tsx Introduced showInviteErrorToast for handling add user failures with an error toast.
.../ui/room/invite-modal.tsx Updated to utilize usersOnRoom prop; derived new members constant for filtering.
.../ui/room/unban-item.tsx Added showUnbanErrorToast function and used toast from use-toast for displaying unban errors.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@lim396 lim396 merged commit 620bd4b into main Jan 30, 2024
4 checks passed
@lim396 lim396 deleted the feat/frontend/chat-channel-error-notification branch January 30, 2024 14:41
const UnbannedUsers = allUsers?.filter(
(user) =>
!bannedUsers?.some((bannedUser) => bannedUser.id === user.id) &&
user.id !== me?.userId,
user.id !== me?.userId &&
user.id !== owner?.userId,
);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

メモ:本当はこんなことするならallUsersの方にroleも持たせた値を返すようなAPIを(新たにでも)設計すべき

@usatie
Copy link
Owner

usatie commented Jan 30, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants