-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Notify user of errors in actions within the chat channel #234
Conversation
lim396
commented
Jan 30, 2024
- BlockやKick、Add userなどchat channel内でのアクションでエラーが発生した際にユーザーにトーストで通知するように変更しました。
- Banの管理画面でユーザー一覧にownerが入ってしまっていたので除外しました。(ownerはBan出来ないため)
WalkthroughThe recent updates across various frontend components focus on enhancing user feedback during error scenarios. Instead of halting operations with exceptions, the system now returns a more graceful "Error" message or displays error toasts for actions like updating room users, kicking users, and managing bans or invites. These changes aim to improve user experience by providing clear feedback during failures, directly affecting the room management and user interaction features within the application. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
const UnbannedUsers = allUsers?.filter( | ||
(user) => | ||
!bannedUsers?.some((bannedUser) => bannedUser.id === user.id) && | ||
user.id !== me?.userId, | ||
user.id !== me?.userId && | ||
user.id !== owner?.userId, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
メモ:本当はこんなことするならallUsersの方にroleも持たせた値を返すようなAPIを(新たにでも)設計すべき
LGTM! |