[frontend/backend] Fixed display name of the DM room

[lim396]

[backend]

• getRoomsのqueryがjoined=trueだった時のテストを追加しました。
• getRoomsのqueryがjoined=trueだった時にroomのメンバー情報も含めて返すように変更しました。

[frontend]

• RoomSidebarで表示していた参加済みroom一覧の表示room名をDMときはDM相手の名前を表示するように修正しました。

[coderabbitai]

Walkthrough

These changes enhance the application's room functionality by improving how room information is fetched and displayed. Specifically, rooms can now include user details based on a condition, and the frontend logic has been updated to better represent direct rooms by showing the other user's name. Additionally, a new test ensures that rooms with joined users are correctly fetched, and a utility method supports this testing by fetching rooms with a specific query.

Changes

Files	Change Summary
backend/src/room/room.service.ts, backend/test/room.e2e-spec.ts	Updated RoomService to conditionally include user details in rooms. Replaced expectRoom with expectRoomWithUsers and added a new test for joined rooms with users info in room.e2e-spec.ts.
backend/test/utils/app.ts	Added getRoomsWithQueryOfJoined method to make GET requests with joined=true.
frontend/app/lib/dtos.ts	Modified RoomEntity type to include an optional users field.
frontend/app/room/rooms-sidebar.tsx	Updated RoomButton to display other user's name in direct rooms and introduced meId prop.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.