-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Handle unhandled errors #289
Conversation
lim396
commented
Feb 28, 2024
•
edited
Loading
edited
- errorを投げたがuncaught errorになっていた箇所を修正しました。
- getUserでnullが返ってきた時にNotFoundページを表示するように修正しました。(404以外もnotFoundに行ってしまうので微妙)
- getRoomでerrorが投げられた時にerrorページが表示されていたのをNotFoundページを表示するように修正しました。(userと同じく404以外もnotFoundに行ってしまうので微妙かも)
- 各ユーザーページでユーザーがアクション(add frined、blockなど)を行った時のエラー通知をtoastでするように修正しました。
WalkthroughThe recent updates focus on improving error handling within various user interaction components of the application. Changes include the addition of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|