Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/oauth/handle error #299

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Feat/oauth/handle error #299

merged 6 commits into from
Mar 7, 2024

Conversation

lim396
Copy link
Collaborator

@lim396 lim396 commented Mar 5, 2024

  • 認可サーバーからのredirect後にqueryに認可codeを持たせてbackendからfrontendにredirectし、frontendから元々認可サーバーからのredirect後に走らせていたAPIを呼ぶように変更しました。
  • APIからのresponseがokではなかった時にqueryにstatus codeとmessageを付けて元いた/signup or /loginにredirectするようにしました。 redirect先ではSearchParamsからquery情報を取得した場合toastでerrorの通知を行うようにしています。
スクリーンショット 2024-03-06 19 04 38 スクリーンショット 2024-03-06 19 03 59

Copy link
Contributor

coderabbitai bot commented Mar 5, 2024

Walkthrough

These updates enhance the OAuth2 authentication flow in both the backend and frontend. The backend sees improvements in naming and logic for OAuth2 login and signup callbacks, alongside removals and modifications in imports and decorators. The frontend introduces new routing files for handling OAuth2 login and signup processes, focusing on fetching authentication data, managing session tokens, and redirecting users based on their authentication status.

Changes

File Path Changes
backend/src/auth/auth.controller.ts - Removed unused imports (Res, Response).
- Modified @Redirect() decorator usage.
- Renamed loginWithOauth42 to loginWithOauth42Callback with logic adjustments.
- Added signupWithOauth42Callback and signupWithOauth42 methods with new logic.
frontend/app/callback/auth/login/oauth2/42/route.ts
frontend/app/callback/auth/signup/oauth2/42/route.ts
Added new files for managing OAuth2 login and signup authentication processes, including data retrieval, session token handling, and user redirection.
frontend/app/ui/auth/login-form.tsx
frontend/app/ui/auth/signup-form.tsx
- Added toast and useSearchParams imports.
- Introduced getStatusText and showErrorToast functions to handle and display error messages based on status codes.
- Utilized useEffect to show error toasts based on query parameters.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@lim396 lim396 merged commit 8fbacb0 into main Mar 7, 2024
4 checks passed
@lim396 lim396 deleted the feat/oauth/handle-error branch March 7, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant