Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fixed some toast to be placed inside useEffect #300

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

lim396
Copy link
Collaborator

@lim396 lim396 commented Mar 5, 2024

  • toast表示時にデベロッパーツールのconsoleにerrorを吐いていた箇所をuseEffectの中に入れて修正しました。

Copy link
Contributor

coderabbitai bot commented Mar 5, 2024

Walkthrough

The overall change across multiple components in the frontend application involves the adoption of the useEffect hook to manage side effects more effectively. Specifically, these changes focus on the enhancement of toast notification logic, ensuring that error or success messages are displayed in response to certain state changes, such as the completion of user actions like adding, removing, blocking, or accepting friend requests. This approach centralizes and streamlines the handling of side effects, improving the application's responsiveness and user experience.

Changes

File Path Change Summary
.../change-password-form.tsx Introduced useEffect to trigger a success toast based on the code state.
.../profile-form.tsx Added useEffect to refactor success toast message logic based on code state.
.../user/accept-friend-request-button.tsx
.../user/add-friend-button.tsx
.../user/block-button.tsx
.../user/cancel-friend-request-button.tsx
.../user/reject-friend-request-button.tsx
.../user/remove-friend-button.tsx
.../user/unblock-button.tsx
Refactored to use useEffect for showing error toasts based on code state. The showErrorToast function is scoped within useEffect across these components, enhancing error handling and control flow.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@lim396 lim396 changed the title [frontend] Fixed toast to be placed inside useEffect [frontend] Fixed some toast to be placed inside useEffect Mar 5, 2024
@lim396 lim396 merged commit 6737e8c into main Mar 5, 2024
4 checks passed
@lim396 lim396 deleted the fix/frontend/toast-error branch March 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant